Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive plugins #12117

Merged
merged 10 commits into from Oct 9, 2020
Merged

Archive plugins #12117

merged 10 commits into from Oct 9, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 28, 2020

Q                       A
License MIT

Archived merged proposal plugins. Also simplified @babel/eslint-shared-fixtures a bit.

Removed Jest's moduleNameMapper configs, as they seems redundant by Yarn.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 28, 2020
["@babel/plugin-proposal-decorators", { decoratorsBeforeExport: false }],
["@babel/plugin-proposal-pipeline-operator", { proposal: "minimal" }],
"@babel/plugin-syntax-bigint",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are removed because one of the following applies:

  • It is enabled by default in latest @babel/parser
  • It is included in @babel/preset-env

@babel-bot
Copy link
Collaborator

babel-bot commented Sep 28, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29064/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 41a2d6b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

module.name_mapper='^@babel\/\([a-zA-Z0-9_\-]+\)$' -> '<PROJECT_ROOT>/packages/babel-\1/src/index'
module.name_mapper='^@babel/\([a-zA-Z0-9_-]+\)$' -> '<PROJECT_ROOT>/packages/babel-\1/src/index'
; Todo: can not make it works, 🤷‍♂️
; module.name_mapper='^@babel/plugin-syntax-import-meta$' -> '<PROJECT_ROOT>/packages/babel-standalone/node_modules/@babel/plugin-syntax-import-meta/lib/index'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I disabled the flow checks on generated plugins because I can't make it work. 41a2d6b#diff-3dcf62f28000b8f05160cab1302d7a6cR24

I believe flow should respect node_modules symlinks and the module.name_mapper should not be specified at all.

@nicolo-ribaudo
Copy link
Member

Yeeee less code 🎉

@nicolo-ribaudo nicolo-ribaudo merged commit 62965e3 into babel:main Oct 9, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the archive-plugins branch October 9, 2020 14:29
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants